mlpack / models

models built with mlpack
https://models.mlpack.org/docs
BSD 3-Clause "New" or "Revised" License
35 stars 41 forks source link

Add YOLO class. #24

Closed kartikdutt18 closed 3 years ago

kartikdutt18 commented 4 years ago

Hey everyone, This PR aims to YOLO class to the models repo. The following is the TO-DO list:

kartikdutt18 commented 4 years ago

The build failure occurs because it doesn't have the newer batchnorm yet.

zoq commented 4 years ago

I guess with https://github.com/mlpack/mlpack/pull/2474 merged, this should build now? Let's rerun the tests.

kartikdutt18 commented 4 years ago

I guess with mlpack/mlpack#2474 merged, this should build now? Let's rerun the tests.

Yes, it builds now.

saksham189 commented 4 years ago

Can you take a look at why the style build is failing?

kartikdutt18 commented 4 years ago

Sure, I will resolve it with the next commit. Thanks for pointing it out.

KimSangYeon-DGU commented 4 years ago

Hey @kartikdutt18 Can you rebase this PR?

KimSangYeon-DGU commented 3 years ago

Thanks for another great contribution :+1:

kartikdutt18 commented 3 years ago

Awesome, Thanks a lot @KimSangYeon-DGU and @saksham189 for all the reviews, suggestions and the help.