search

mlpack / models

models built with mlpack
https://models.mlpack.org/docs
BSD 3-Clause "New" or "Revised" License
35 stars 41 forks source link

Where to put convert class #26

Closed heisenbuug closed 3 years ago

heisenbuug commented 4 years ago

I have implemented a Convert class as per the requirement of the issue In which directory should we put this new code? Link to my implementation. Once decided I can make a PR accordingly.

kartikdutt18 commented 4 years ago

Hey @heisenbuug, Sorry for the late reply. I'm completely forgot about this. What do you thing about having a separate directory like dataset_utils or something.

heisenbuug commented 4 years ago

Hey @kartikdutt18 , it's fine. Yea...I think it would totally make sense to do that...I will make a PR accordingly .

mlpack-bot[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! :+1:

mlpack-bot[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! :+1:

shrit commented 3 years ago

@kartikdutt18 Do you need to keep this one open? Thanks

heisenbuug commented 3 years ago

No, we don't need this one open. Sorry for not updating,