mlpack / models

models built with mlpack
https://models.mlpack.org/docs
BSD 3-Clause "New" or "Revised" License
35 stars 41 forks source link

Added Convert Function as discussed on Issue#22 #33

Open heisenbuug opened 3 years ago

heisenbuug commented 3 years ago

Issue link

Added a new folder dataset_utils and currently the convert function can convert

mlpack-bot[bot] commented 3 years ago

Thanks for opening your first pull request in this repository! Someone will review it when they have a chance. In the mean time, please be sure that you've handled the following things, to make the review process quicker and easier:

Thank you again for your contributions! :+1:

mlpack-bot[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! :+1:

mlpack-bot[bot] commented 3 years ago

Thanks for opening your first pull request in this repository! Someone will review it when they have a chance. In the mean time, please be sure that you've handled the following things, to make the review process quicker and easier:

Thank you again for your contributions! :+1:

heisenbuug commented 3 years ago

Hey @kartikdutt18, I will add json. xml -> csv by the end of today or tomorrow... I will also keep in mind the edits you suggested in here...

heisenbuug commented 3 years ago

Hey @kartikdutt18, I noticed something... If you go to the example here to see how the convert function works you can see that we gave an input .csv file with 10 rows and we got 1 XML file per row as output making total to 10 .xml files as output, is this right? Or do we also want an option to put all these in the same .xml file?

Shouldn't we have to put all of them in 1 file?

Also, we are planning to reduce boost dependencies, right? So should we use boost here?