search

mlpack / models

models built with mlpack
https://models.mlpack.org/docs
BSD 3-Clause "New" or "Revised" License
35 stars 41 forks source link

Added ZFNet model #4

Closed prince776 closed 4 years ago

prince776 commented 4 years ago

I've added ZFNet model with the same structure as created in #3.

kartikdutt18 commented 4 years ago

Hey @prince776, wasn't @codeboy5 working on this. Great addition though but It might be a while before we add this model. I think the first step would be setting up this repo before actually start adding other models. Thanks 👍. There are lot of changes in cmake, data loader and maybe model. There will also be a testing unit that I'll be setting up. So you would have to sit tight for a couple of days. Thanks again.

codeboy5 commented 4 years ago

Hi @kartikdutt18. I've already done the implementation but didn't add a PR due to the restructuring going on, was waiting for it to be completed. I opened the issue a week ago. https://github.com/mlpack/examples/issues/63

prince776 commented 4 years ago

Oh right, I just saw he was working on it. What should I do then?

Also yes you're right, restructuring and setting up the repo should be done first. I'll try to help with it too.

prince776 commented 4 years ago

Hi @kartikdutt18. I've already done the implementation but didn't add a PR due to the restructuring going on, was waiting for it to be completed. I opened the issue a week ago. mlpack/examples#63

Sorry @codeboy5 I didn't see the issue you opened. Should I close this now, since you've already completed it too.

codeboy5 commented 4 years ago

If I was not done with the PR, I would have said to go on and merge this, But since I am completely done with it, maybe you can work on something similar. I was thinking that squeezenet might be a good addition if you wanna take that up.

codeboy5 commented 4 years ago

Hi @kartikdutt18. I've already done the implementation but didn't add a PR due to the restructuring going on, was waiting for it to be completed. I opened the issue a week ago. mlpack/examples#63

Sorry @codeboy5 I didn't see the issue you opened. Should I close this now, since you've already completed it too.

That would be great :) Sorry for the time you had to put in.

prince776 commented 4 years ago

Ok so I will close it and work on squeezenet.

codeboy5 commented 4 years ago

Ok so I will close it and work on squeezenet.

Thanks, looking forward to your PR. :)

prince776 commented 4 years ago

That would be great :) Sorry for the time you had to put in.

It's ok, I should have seen issues/PRs related to it first :)