search

mlpack / models

models built with mlpack
https://models.mlpack.org/docs
BSD 3-Clause "New" or "Revised" License
35 stars 40 forks source link

Fix build. #47

Closed kartikdutt18 closed 3 years ago

kartikdutt18 commented 3 years ago

closes #46.

rcurtin commented 3 years ago

Looks like everything is building fine, but maybe the URLs are wrong in utils_test.cpp? Let me know if you need me to add any files to mlpack.org. :+1:

kartikdutt18 commented 3 years ago

Hey @rcurtin, It would be great if you could upload the datasets in this link to mlpack.org/datasets. This should fix the build and not break the datasets link in the repo.

rcurtin commented 3 years ago

I think those are already there:

http://mlpack.org/datasets/iris.csv http://mlpack.org/datasets/mnist.tar.gz http://mlpack.org/datasets/PASCAL-VOC-Test.tar.gz http://mlpack.org/datasets/USCensus1990.tar.gz

There was a bug where the correct version of the datasets was not being downloaded, so if those builds are more than ~a week old, that may be the issue here and maybe we just need to re-run.

kartikdutt18 commented 3 years ago

Awesome, the build is passing now!

kartikdutt18 commented 3 years ago

Great, Thanks everyone for the reviews and suggestions.