search

mlpack / models

models built with mlpack
https://models.mlpack.org/docs
BSD 3-Clause "New" or "Revised" License
33 stars 42 forks source link

Use catch2 instead of ctest #69

Closed Aakash-kaushik closed 3 years ago

Aakash-kaushik commented 3 years ago

ctest reports tests to pass even if they are failed, this is done just so we know if some tests fail.

reference comment: https://github.com/mlpack/models/pull/63#issuecomment-870899105

Aakash-kaushik commented 3 years ago

How does this even happen, please ignore this PR for now, i didn't mean to include all the resnet changes.

birm commented 3 years ago

Do you need guidance on fixing your branch?

Aakash-kaushik commented 3 years ago

Do you need guidance on fixing your branch?

I would highly appreciate it.

zoq commented 3 years ago

Looks like you created a branch from the resnet branch and not from the master branch?

Aakash-kaushik commented 3 years ago

Looks like you created a branch from the resnet branch and not from the master branch?

This was a bit more messier than that, if it's fine i would open another PR by tomorrow or just fix this one up, i mean just opening another one would be pretty easy to me

zoq commented 3 years ago

Sure, whatever is easier for you.