search

mlpack / models

models built with mlpack
https://models.mlpack.org/docs
BSD 3-Clause "New" or "Revised" License
35 stars 40 forks source link

Refactor models repository for mlpack 4 changes #81

Closed rcurtin closed 2 years ago

rcurtin commented 2 years ago

Mostly this removes the explicit uses of namespaces and changes headers to include only mlpack.hpp.

The tests do not all currently work---but that's not a change from the current state of the repository. Some of the models still need to be adapted to the ann-vtable transition from a handful of months back.

I also had to make a couple small changes to get some of the tests (which are currently commented out) to compile at all.

In the future I hope to uncomment these tests one by one and get them working again too.

rcurtin commented 2 years ago

Okay, I got it to work! It took some amount of CMake and build system changes to re-enable the OS X and Windows builds too.

zoq commented 2 years ago

Any update on the OVH binder issue?

rcurtin commented 2 years ago

Not going well, still waiting on a response. I sent another ping. If I hear nothing I'll open an issue on a repository somewhere.