Lemma 1 parenthesis seem wrong

mlpen / Nystromformer

Apache License 2.0

356 stars 41 forks source link

Lemma 1 parenthesis seem wrong #2

Closed thomasw21 closed 3 years ago

thomasw21 commented 3 years ago

Hello, first of all great work! This looks very promising.

As I'm reading a bit more in depth, I'm wondering if you might have an error on parenthesis in lemma 1. Both the code, and the proof seem to indicate it.

The last term should apply only to AZ instead of (15I - AZ) no?

This would "fix" the following lines in the proof

yyxiongzju commented 3 years ago

Hi @thomasw21, Thanks for the nice catch. I will update it.

alex26-research commented 3 years ago

Hi @thomasw21, Thanks for the nice catch. I will update it.

Hi. Thank u for Nystromformer. Will be code for keras/tensorflow?

yyxiongzju commented 3 years ago

Hi @alex26-research, the code is just for PyTorch now.