search

mlr-archive / mlr-tutorial

The mlr package online tutorial
http://mlr-org.github.io/mlr/
20 stars 11 forks source link

Fix travis issue #132

Closed pat-s closed 6 years ago

pat-s commented 6 years ago

Introduced by https://github.com/mlr-org/mlr/commit/f947f414438cfb3bfe992c3634d4529de566ff6b

larskotthoff commented 6 years ago

What's the problem here? As far as I can see the commit that you've linked to has nothing to do with the fix.

pat-s commented 6 years ago

Ah sorry, meant this commit: https://github.com/mlr-org/mlr/commit/455f3e275e56f697c7cd26385e06c339ba5df743

The commit introduced a name change in sonar.task and iris.task changing a - to a _ which causes the build to fail. See last gh-pages builds of mlr-tutorial, e.g. https://travis-ci.org/mlr-org/mlr-tutorial/builds/313653705

The builds of this PR run fine but error due to timeout.

jakob-r commented 6 years ago

Hopefully travis can turn green within the time limit. Then it can be merged.

jakob-r commented 6 years ago

Knitting file 'partial_dependence.Rmd' ... took longer than 10mins?

pat-s commented 6 years ago

Knitting file 'partial_dependence.Rmd' ... took longer than 10mins?

I also do not know what causes this. Travis trusty update, mlr update, mlr-tutorial update?

jakob-r commented 6 years ago

Well. I don't care at the moment. The important part was fixed and was knitted without errors.