search

mlr-archive / mlr-tutorial

The mlr package online tutorial
http://mlr-org.github.io/mlr/
20 stars 11 forks source link

update 'handling of spatial data' with updated approach in mlr #139

Closed pat-s closed 6 years ago

pat-s commented 6 years ago

https://github.com/mlr-org/mlr/commit/2ebd2f29bb8adcf5f865ca3a6b579c71ca96c072

pat-s commented 6 years ago

@jakob-r @larskotthoff this is blocking the build. See https://travis-ci.org/mlr-org/mlr-tutorial/builds/334603804.

Can we merge this? Should be merged together with https://github.com/mlr-org/mlr-tutorial/pull/140 as both #140 and #139 will only pass if the other is merged, too.

larskotthoff commented 6 years ago

Hmm, could you make one PR for both in this case? I'd like to see the build pass before merging.

pat-s commented 6 years ago

I assume it will still fail because of https://github.com/mlr-org/mlr-tutorial/issues/141

Edit: As expected

zmjones commented 6 years ago

i found the bug and am working on it now. will have to issue a pr in mlr and then it should work.

jakob-r commented 6 years ago

Why is the logo part of this PR? Can you merge in master pls?

pat-s commented 6 years ago

Oh no it auto merged all the devel/ files again.. Cleaning up later.

Sent with GitHawk

pat-s commented 6 years ago

@jakob-r @larskotthoff ready to merge

larskotthoff commented 6 years ago

Thanks, merging.