mlr-archive / mlr-tutorial

The mlr package online tutorial
http://mlr-org.github.io/mlr/
20 stars 11 forks source link

New logos - for folder "img" and "custom_theme/img" #146

Closed juliabrosig closed 6 years ago

jakob-r commented 6 years ago

Looks pretty bad here: tutorial screen shot

jakob-r commented 6 years ago

For the blog I can set the change: However it looks a bit strange, as we know have the term mlr 3 times nearly in the same typo.

image

mb706 commented 6 years ago

Maybe color the little bricks white in mlr_white.png (or also use a background there)

Also, why not change "mlr: Machine Learning for R." to just "Machine Learning for R." when the logo is shown next to it and remove the "mlr-org" text entirely.

juliabrosig commented 6 years ago

regarding the tutorial - do you think it looks better if the mlr = white and the squares = grey? or maybe it also looks quite boring then. But then we would have to change the background color of the tutorial ...

mb706 commented 6 years ago

This is #b0c4de for the blocks: mlrx

pat-s commented 6 years ago

Maybe we could focus the efforts on implementing the new logo in the pkgdown approach? I am just working on replacing the mlr text that links to the site index with the logo. Everyone should have the rights to add commits to my PR.

See the following line for the logo implementation in the navbar:

https://github.com/pat-s/pkgdown/blob/cc1579abcf00cb11bc856e48f3b9d3c91432c2c2/inst/templates/navbar.html#L10

jakob-r commented 6 years ago

Sounds reasonable.

jakob-r commented 6 years ago

So I guess this issue can be closed @pat-s ?

pat-s commented 6 years ago

Yes. We should clean up here. I can't ;)