Closed larskotthoff closed 8 years ago
Build broken because of other issues. Wait with merge until fixed.
I am honestly impressed by the numbers of pages and that it looks so good in most parts but there are some issues still left
Personally as I mentioned before. I would try do drop the "Integrated *" parts in the pdf version because
Do the external links work? Not for me.
For me they work, the links to rdocumentation as well as links to papers and other websites.
Dropping the integrated* parts would cause some broken links throughout. I don't see the argument for them being outdated quickly as we regenerate the PDF every time the tutorial is built.
Headers now added, see new attachment -- they overlap on some pages, but can be customised in the usual LaTeX way.
1) First of all, i didnt want to be "rude" to Lars.
2) Thanks a bunch! This is very cool! Apparently we don't have to write the mlr book :) It exists.
3) WRT the appendix tables. I see possibilities to change the layout here, but i think we should drop them as @jakob-r suggested.
4)
Authors are no problem either. What's the author list?
Just take everybody how did a commit on the repo? And we can ask over slack whether we have forgotten someone.
5) Is it possible top have some chapter numbering?
Thanks again !
I haven't found out yet where/how this is happening, but none of the figures is where it is supposed to be. For example on p. 24 there should be a scatterplot instead of the threshold-vs-perf plot and p. 35 shows ROC curves instead of the learner-prediction plots.
Argh, the filenames generated by knitr are not unique. I'll fix that.
Thanks very much.
who is IcedragonP
I think this is @PhilippPro (?) EDIT: Yep. I'm sure now, you can see this in PR #13 for example.
Regarding the author list: Did you also look in the old mlr gh-pages branch?
We need to add Michel who wrote the wrapper page and did many other nice things. Tobias Kühn wrote the imbalanced classification page. (He is probably not in the history at all because he sent his stuff by email and I committed it for him.)
yes (twice)
who is IcedragonP I think this is @PhilippPro (?)
it is either P Probst, who must be added. Or somebody irrelevant.
And studerus and Dominik Kirchhoff had one commit each.
Did they do relevant, larger changes or just mini commits?
authors: giuseppe did the classifier calibration stuff.
WRT numbering and structure: thx much better now. can we still have the "superstructure" with basic, advanced, extend be somehow visible in there?
authors: giuseppe did the classifier calibration stuff.
Zach wrote this (https://github.com/mlr-org/mlr-tutorial/commits/gh-pages/src/classifier_calibration.Rmd)
And studerus and Dominik Kirchhoff had one commit each.
Did they do relevant, larger changes or just mini commits?
studerus: no Dominik: wrote a small section about the survival learners on the create learner page
Figures: We can probably set some kind of magnification somewhere? Didn't see anything obvious though.
This is actually easily done by setting the internal drawing size of the graphic device a bit smaller. This would be my goto values:
opts_chunk$set(
fig.width = 8,
fig.height = 5
)
IcedragonP = Philipp Probst
So you can delete IcedragonP.
Thx very much, Lars!!!
Re: Figures Sorry for not doing this sooner, I just looked a little more closely at the figures.
So my proposal is
Ok, sounds good. There are many imperfections anyway and we can't fix all of them now.
I've fixed the author list.
Ok, sounds good. There are many imperfections anyway and we can't fix all of them now.
Unfortunately... But I fixed most of the plots now. Wanted to fix the table in the visualization section next.
We need to add Janek to the author list.
Small issues:
What's the verdict on this? Fixing all the minor issues will take a lot of effort and time. I vote to merge this now so that we have a reasonable, but not perfect PDF, and improve this later.
I'm also pro merging.
I'm also pro merging.
then do it.
Ok, why didn't this squash the commits when I merged? It seems to be set up to do that?
1) if the tutorial exists now as PDF, can we pls put in on arxiv ASAP? as that was the motivation.
2)
Ok, why didn't this squash the commits when I merged? It seems to be set up to do that?
the settings now seem to allow squashing merges and normal, multi-commit merges. the normal mlr repo only allows squash merges. i will change this here, now too. but the next time: simply check the options for this. this is the only thing that influences thus. (and where you click....)
Changed build to generate PDF version of tutorial. This is generating the tutorial with external PDF figures, collating the markdown files, fixing the internal links, adding a title, converting to PDF. Then generating the tutorial with embedded SVG figures. PDF version will be committed with the rest of the tutorial.
This is generating the entire tutorial twice, but I'm not sure we care about it since it happens on Travis anyway.
Fixes #50.
mlr-tutorial.pdf