search

mlr-org / ParamHelpers

Helpers for parameters in black-box optimization, tuning and machine learning.
https://paramhelpers.mlr-org.com
Other
25 stars 9 forks source link

OptPath env now has empty parent #188

Closed mb706 closed 6 years ago

mb706 commented 7 years ago

This is helpful when saving OptPaths to files

Fixes #186

berndbischl commented 7 years ago

shall we test this too? so it cannot get changed back?

jakob-r commented 6 years ago

@mb706 Can you tell us shortly what the side effects of the different parent environments are?

jakob-r commented 6 years ago

Well I guess we never look something up within the opt.path, so after all we never expect to find an object of the parent environment so we can set the parent environment to emtyenv().

mb706 commented 6 years ago

I don't entirely remember, but I think the issue was that saving the opt.path also put the parent environment in the savefile under some circumstances, thus bloating the file.