Segfault in C code if lhs::randomLHS returns 1.0 for some reason

mlr-org / ParamHelpers

Helpers for parameters in black-box optimization, tuning and machine learning.

https://paramhelpers.mlr-org.com

Other

25 stars 9 forks source link

Segfault in C code if lhs::randomLHS returns 1.0 for some reason #211

Open mb706 opened 5 years ago

mb706 commented 5 years ago

Maybe I'm being pedantic, but IMHO this shouldn't happen. Even though runif gives us the guarantee that it never evaluates to 1, lhs doesn't do that. This came up in #210, see the code here and here