mlr-org / bbotk

Black-box optimization framework for R.
https://bbotk.mlr-org.com
GNU Lesser General Public License v3.0
20 stars 9 forks source link

Add support for irace v4 #226

Open MLopez-Ibanez opened 7 months ago

MLopez-Ibanez commented 7 months ago

Hi,

The next version of irace: https://github.com/MLopez-Ibanez/irace/tree/v4 will have some breaking changes: https://mlopez-ibanez.github.io/irace/news/index.html

The list is not complete yet but among them, there is the call to irace() here:

https://github.com/mlr-org/bbotk/blob/70f3f96ff0023066aa8eaa7c97484f0d6e518663/R/OptimizerIrace.R#L182-L185

that should be replaced by:

      scenario = c(list(maxExperiments = terminator$param_set$values$n_evals, targetRunnerData = list(inst = inst), parameters = paradox_to_irace(inst$search_space, pv$digits)), pv)
      # run irace
      res = invoke(irace::irace, scenario = scenario, .opts = allow_partial_matching)

Also, a few lines below, instead of load() you can use iraceResults = read_logfile() introduced in irace 3.5

be-marc commented 6 months ago

Hey, thanks for the information. I assume you are uploading to CRAN and we have 2 weeks to upload bbotk with the changes? If there are any more changes please let me know.

MLopez-Ibanez commented 6 months ago

It will still take some time to reach CRAN. Probably not before June. Other changes that may be relevant to you:

MLopez-Ibanez commented 3 months ago

I am doing the final tests before uploading irace v4 to CRAN. This may still take me at least a few days, more if I find bugs. A non-exhaustive list of changes:

There may be other things that I have missed. If you find any problems or crashes, please let me know. It would be great to fix them before uploading to CRAN.

MLopez-Ibanez commented 3 months ago

You can install the next version of irace from git: https://github.com/MLopez-Ibanez/irace

This version will go to CRAN in the next few weeks and break bbtok.

be-marc commented 3 months ago

Thanks for all the information. #243 contains the changes. We will upload when CRAN informs us. The installation of your packages somehow does not work with pak::pak("MLopez-Ibanez/irace"). So our ci fails but devtools::test() works locally.

MLopez-Ibanez commented 3 months ago

I fixed the problem and pak install should work now.