search

mlr-org / bbotk

Black-box optimization framework for R.
https://bbotk.mlr-org.com
GNU Lesser General Public License v3.0
20 stars 9 forks source link

Remove all Dictionaries #84

Closed be-marc closed 4 years ago

be-marc commented 4 years ago

We could remove mlr_terminators and mlr_optimizers to have a more basic package with no references to mlr3. The dictionaries are more useful in mlr3tuning as mlr_terminators and mlr_tuners.

berndbischl commented 4 years ago

this concerns the complete "sugar" file

jakob-r commented 4 years ago

Why??? To remove the terminator dictionary would be really annoying. We would have to add it in mlr3tuning, mlr3fselect, mlr3mbo (...?) separately. A consistent term() sugar function is also important.

I accept that the name mlr_terminators is badly chosen but a renaming is probably a far better decision than a deletion!

berndbischl commented 4 years ago

1) The idea was never to delete them but to move them-.

2) My opinion is that they are not needed in bbotk, and if sugar is not needed (and might create problems) we should not have it-

Unfortunately, you have a point with mlr3fselect. I would prefer adding the sugar only in mlr3tuning, but that doesn't work.

Which is "Mist" :(