search

mlr-org / bbotk

Black-box optimization framework for R.
https://bbotk.mlr-org.com
GNU Lesser General Public License v3.0
21 stars 9 forks source link

Add OptimizerNLoptr #92

Closed be-marc closed 4 years ago

be-marc commented 4 years ago

nloptr has it's own termination criteria. Some could be replaced with our Terminator subclasses but other like xtol_rel are specific to the used algorithm

However, there is some variation in how the different algorithms implement x tolerance tests

(https://nlopt.readthedocs.io/en/latest/NLopt_Introduction/)

Should we just use the internal termination of nloptr or replace some with our Terminator subclasses?

codecov-commenter commented 4 years ago

Codecov Report

Merging #92 into milestone will increase coverage by 0.18%. The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           milestone      #92      +/-   ##
=============================================
+ Coverage      97.69%   97.87%   +0.18%     
=============================================
  Files             26       27       +1     
  Lines            433      471      +38     
=============================================
+ Hits             423      461      +38     
  Misses            10       10
Impacted Files Coverage Δ
R/OptimizerNLoptr.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1df071d...9f9c33d. Read the comment docs.