mlr-org / mlr

Machine Learning in R
https://mlr.mlr-org.com
Other
1.65k stars 404 forks source link

extractFDAFeatures API #1548

Closed berndbischl closed 4 years ago

berndbischl commented 7 years ago

ok, one problem is that we would like to have that function "act" on a task.

but we also need a basic "workhorse". for this we need to act on data (and target, do we really need the target for anything?).

so the current API is good, but we need to document that one line in "data" is always one complete time series.

berndbischl commented 7 years ago

and really learn from the design in Impute.R and ImputeMethods.R to see how to delegate to specific algorithms, and how "reimpute" works during prediction time.

pfistfl commented 7 years ago

So, I worked on this since friday:

The code currently resides in the fda_pull1_task_featExtract branch.

It is mostly done similar to impute.R and imputeMethods.R

Current API:

  t = extractFDAFeatures(fuelSubset.task, 
     feat.methods = list("UVVIS" = extractFDAMean(),
                                    "NIR" = extractFDAFourier(trafo.coeff = "amplitude")))

It should return a Task, but I have not solved that yet.

It currently returns a list, where

extractFDAFeatures can be called for a data.frame as well, then target, fd.features and fd.grids, usually contained in the TaskDeschave to be supplied as well.

For predict phase we can pass a Task and a extractFDAFeatDesc

  t2 = reExtractFDAFeatures(fuelSubset.task, t$desc)

Questions:

@smilesun @lbeggel

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.