Closed pfistfl closed 4 years ago
Side remark: the example in extractFDAfeatures.R does not work
@lbeggel: Fixed Example
@smilesun
Perfect! I stumbled upon one more thing. In convertTaskToFDATask
we check for the correct specification of fd.features
and fd.grids
. If we want to be able to do the extraction of data.frame's as needed for the wrapper, I have to check all those things during extraction aswell.
Alternative1: Only allow extraction for tasks, this ensures correct specification of fd.grids and fd.features
Alternative2: Create helper which does the checking and use it for data.frames.
Additionally, discuss function names. I am not super content with how they turned out. I will try to have everything ready and documented by friday.
@pfistfl Alternative3 : if the user pass a data frame, it is by default to be a single channel of features !
In regards to Alternative3: As we would do with the task. This means again, just copy-pasting the code from convertTaskToFDATask
.
@pfistfl I don't get what you mean.
I think in case the user supplies a data.frame we have to give the opportunity to specify fd.features
and fd.grids
. This means we have to check whether these provided parameters are valid.
Passing nothing and assuming its a single functional covariate is a good default.
Additionally, @Stevo15025 wanted to use the extractFourierFeatures for time series data. We should discuss a suitable format for this. Is the current format suitable for this?
Yes, it should be. time series = funcitonal covariate that is one line.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
I will do a quick writeup of what I have currently done, would be glad about some input.
FDATasks
areTasks
that contain additional Description elementsfd.features
andfd.grids
. Thefd.features
describe which columns belong to which functional covariate, thefd.grids
specify the measurement grid for each functional covariate.I implemented some rather stupid functions for Feature Extractions, such as min, max, mean, etc., along with the possibility to extract Fourier Transform Features.
The current call looks like this: (UVVIS, NIR are the functional covariates, each corresponding to a few hundred columns in the same data.frame associated with the task.)
Questions:
task
? Currentlyt
contains a normal task. All functional features are dropped, all scalar features are kept as-is. The extracted features are appended (with propper naming i.e UVVIS.mean, NIR.min, NIR.max, ...)$desc Extraction of features from functional data: Target: heatan Functional Features: 2; Extracted features: 2
Can we extend the PreprocWrapper somehow, so it works on tasks? For now I have to specify features and grids for every learner which is rather cumbersome. (I might be overlooking something as well...)
Currently only one feature Extraction method per functional covariate is allowed. I think somehow combining featureExtractions might become handy. Should this be done by allowing multiple
feat.methods
per variable?Possibly rename
extractFDAFeaturesFourier
andextractFDAFeaturesWavelets
toextractFourierFeatures
andextractWaveletFeatures
. Have the Original names for the feature extraction methods on FDA Data described above and the new names for a more general method that can be somehow used on time series data as well.All those changes are in the fda_pull1_task_featExtract branch @smilesun @lbeggel