mlr-org / mlr

Machine Learning in R
https://mlr.mlr-org.com
Other
1.64k stars 405 forks source link

add adaboostm1 learner from rweka #1845

Closed berndbischl closed 6 years ago

berndbischl commented 7 years ago

reason: there is no good classic adaboost in R (that i know?).

ada in package ada is EXTREMELY slow

giuseppec commented 6 years ago

There is https://cran.r-project.org/web/packages/fastAdaboost/fastAdaboost.pdf which implements Adaboost based on C++ backend code. Not sure if this is better than the RWeka learner, at least they have unit tests in their repo https://github.com/souravc83/fastAdaboost

Maybe someone could do a quick microbenchmark to see which one is faster (e.g. innolab guys).

alona-sydorova commented 6 years ago

we'll check it out

giuseppec commented 6 years ago

Cool. Just do a mini benchmark first and share your results here. We can then decide wether you can implement fastAdaboost or the rweka adaboost. (Btw. installing the rweka package can be horrible due to rjava dependency, so if you encounter any problem just ask.)

alona-sydorova commented 6 years ago

we have found out that fastAdaboost is implemented only for binary classification while RWeka adaboost can work with multilabel classification tasks. should we still compare their performance or is it more important for you to have the possibility of having more than 2 classes in the task?

giuseppec commented 6 years ago

Hm, as the currently used adaboost learner is also only able to do binary classification, I would say that a mini benchmark will still help in making a decision.

alona-sydorova commented 6 years ago

so, we did some micro benchmarking, with 3 different datasets and 50 to 200 iterations as well as different classifiers for RWeka and found out that RWeka still performs significately better than fastAdaboost

giuseppec commented 6 years ago

Do you have the code for this benchmark, so that I could reproduce this on my machine? But it sounds like you can already implement the RWeka adaboost. Just do a PR for this!

alona-sydorova commented 6 years ago

I've sent you the script in Slack