search

mlr-org / mlr3

mlr3: Machine Learning in R - next generation
https://mlr3.mlr-org.com
GNU Lesser General Public License v3.0
948 stars 85 forks source link

Should Learners that implement '$loglik()' have a "loglik" property? #1101

Closed mb706 closed 5 days ago

mb706 commented 3 months ago

If so, it is not documented here:

https://github.com/mlr-org/mlr3/blob/d72be13637058ebabf00dc169ca51087db55b74d/R/Learner.R#L62-L64

If not, then the AutoTuner should be modified: https://github.com/mlr-org/mlr3tuning/blob/6eae837fd9c8bbabe4029b243a2677b83047fe6f/R/AutoTuner.R#L244-L246

berndbischl commented 3 months ago

sloglik, AIC and BIC are basically "feature creep" -- which we can clearly see from this issue here. where we now discuss, to produce EVEN MORE infrastructure what pretty nobody needs who uses mlr3. nearly no supported model has "loglik", no one wants to use insample metrics like AIC when using mlr3 with ML models.

and with custom code this would even still be possible

be-marc commented 5 days ago

$loglik method is removed