search

mlr-org / mlr3benchmark

Analysis and tools for benchmarking in mlr3 and beyond.
https://mlr3benchmark.mlr-org.com/
GNU Lesser General Public License v3.0
12 stars 2 forks source link

fix: use `%in%` in `BenchmarkAggr$subset()` rather than `==` #38

Closed jemus42 closed 10 months ago

jemus42 commented 10 months ago

I found that $subset() threw a warning if learner or task was a character length greater 1. While I wasn't able to create a simple regex to reproduce it, I don't see any downside to using %in% here though, which appears to work just fine in my case.

jemus42 commented 10 months ago

Ah nevermind, I see that #36 also addresses this while also changing other parts of the class.