mlr-org / mlr3book

Online version of Bischl, B., Sonabend, R., Kotthoff, L., & Lang, M. (Eds.). (2024). "Applied Machine Learning Using mlr3 in R". CRC Press.
https://mlr3book.mlr-org.com/
MIT License
252 stars 59 forks source link

Chapter 10 Comments #438

Closed RaphaelS1 closed 1 year ago

RaphaelS1 commented 1 year ago

Style

Content

Structure

RaphaelS1 commented 1 year ago
pbiecek commented 1 year ago

@RaphaelS1 I've submitted new version here https://github.com/mlr-org/mlr3book/pull/508

There is still a lot of improvement to be made, but as the change of the FIFA -> penguins example has forced a lot of changes so I prefer to make this version v0.5 available

Next steps: exercises and further work on the structure

larskotthoff commented 1 year ago
pbiecek commented 1 year ago

Regarding "10.4 suggest changing the analysis for prediction of good credit rather than bad to be consistent with the rest of the chapter. This confused me a few times when looking at the graphs because they seemed to show the opposite of what I expected."

The iml section is ,,class neutral'' i.e. both classes are presented.

The counterfactuals section shows what to do to move from bad to good, what is consistent with typical application of ,,what to do to get a credit''

The DALEX section focuses on the 'probability of default' i.e. risk of not repaying credit - classical approach in credit scoring.

RaphaelS1 commented 1 year ago

@larskotthoff can you confirm if comment from @pbiecek above needs to be addressed by you here or in the PR before we can merge?