search

mlr-org / mlr3extralearners

Extra learners for use in mlr3.
https://mlr3extralearners.mlr-org.com/
89 stars 48 forks source link

update for `aorsf` version 0.1.2 #338

Closed bcjaeger closed 8 months ago

bcjaeger commented 9 months ago

Hello!

I am planning to release aorsf version 0.1.2 soon. This release will include support for classification and regression oblique random forests, and these new features introduce some new parameters into orsf, deprecate the current orsf_control functions in favor of outcome-specific ones, and replace the orsf_fit class with ObliqueForest. Last, the ArXiv paper that we reference in the mlr3 docs has now been published in Journal of Computational and Graphical Statistics, so the bib data can be updated. I've prepared a PR with these changes. Would it be okay for me to submit this PR for you to review?

sebffischer commented 9 months ago

Hey @bcjaeger, thanks a lot for actively maintaining the aorsf Learner! I am will be glad to review your Pull Request! :)

bcjaeger commented 9 months ago

Awesome! I will give it a review tonight and post it tomorrow. Thank you!