search

mlr-org / mlr3filters

Filter-based feature selection for mlr3
https://mlr3filters.mlr-org.com
GNU Lesser General Public License v3.0
20 stars 8 forks source link

importance filter default is bad #155

Open mb706 opened 1 year ago

mb706 commented 1 year ago

the importance filter by default uses the "featureless" learner by default, which makes the filter basically useless. There are likely very few cases in which the user wants to initialize the importance filter with the featureless learner. Therefore, the learner should not have a default; when constructing the importance filter without providing a learner, an error should be thrown instead.

sebffischer commented 1 year ago

I agree: https://github.com/mlr-org/mlr3filters/issues/130

sebffischer commented 1 year ago

I think these choices were made to make the as.data.table() conversion work. Maybe we should implement your solution from mlr3pipelines in mlr3misc.

sebffischer commented 1 year ago

https://github.com/mlr-org/mlr3misc/pull/92 would help for the dict -> dt conversion