search

mlr-org / mlr3gallery

Case studies using mlr3
https://mlr3gallery.mlr-org.com
21 stars 9 forks source link

delete files that are listed in .gitignore (html and auxillary), update README #53

Closed sumny closed 4 years ago

sumny commented 4 years ago

For consistency with the current workflow, delete all files that are listed in .gitignore (importantly html and auxiliary files that were generated when rendering a local preview). Also updated REAMDE to make contributors aware of this.

jakob-r commented 4 years ago

There are still some html files that gets changed with this PR. This seems to be wrong?

sumny commented 4 years ago

There are still some html files that gets changed with this PR. This seems to be wrong?

Yes :( seems like this is not the real solution. I tried to automate it calling git ls-files -i --exclude-from=.gitignore and then removing these via git rm --cache.

sumny commented 4 years ago

@jakob-r I guess it looks better now?

sumny commented 4 years ago

So the problem is that the CI automatically re-renders the posts (Deploy from Github Actions build 104717928 [ci skip]) and therefore the html files in docs/posts are changed?

jakob-r commented 4 years ago

Yes. Is that intended?

sumny commented 4 years ago

Yes. Is that intended?

I guess so, at least in the README it states: "All posts are rendered on every push to ensure that all posts can be run without issues."

sumny commented 4 years ago

Yes. Is that intended?

I guess so, at least in the README it states: "All posts are rendered on every push to ensure that all posts can be run without issues."

@pat-s do you have any comments here?

pat-s commented 4 years ago

Ok, let's see what happens to master after merge.