Closed berndbischl closed 4 years ago
here is an example why you should not close this too early: at leats documentation for the Sampler is missing
and: if you document this properly a) I dont need the lengthy example code in the issue here, i think. i don't want to complain too much about it, an example usually never hurts b) consider adding this to "@examples" for other users
please add
a) some assert that the sampler exactly contains the same params of the paramset, without the budget.
b) a unit test that assert is there
i dont know i removed the line that the budget param can be in the Sampler and is ignored, in docs. usually i dont like this. not sure whats best here
a) and b) is done
I think it is done
Example (please make sure you are on
seb-dev
branch):