search

mlr-org / mlr3hyperband

Successive Halving and Hyperband in the mlr3 ecosystem
https://mlr3hyperband.mlr-org.com
GNU Lesser General Public License v3.0
18 stars 5 forks source link

Fix bug in MO non-dominated sorting #63

Closed juliambr closed 4 years ago

juliambr commented 4 years ago

Problem: sample(to_remove, 1) is equivalent to sample(1:to_remove, 1) for to_remove being a integer vector of length one; this is not what we want at this place (in case to_remove happens to be a vector of length one).

codecov-commenter commented 4 years ago

Codecov Report

Merging #63 into master will increase coverage by 0.06%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   91.86%   91.93%   +0.06%     
==========================================
  Files           3        3              
  Lines         123      124       +1     
==========================================
+ Hits          113      114       +1     
  Misses         10       10
Impacted Files Coverage Δ
R/nds_selection.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d25414f...b211562. Read the comment docs.