mlr-org / mlr3learners

Recommended learners for mlr3
https://mlr3learners.mlr-org.com
GNU Lesser General Public License v3.0
89 stars 14 forks source link

Connect learner ORSF from package obliqueRSF #106

Closed RaphaelS1 closed 4 years ago

RaphaelS1 commented 4 years ago

Checklist before requesting a review

RaphaelS1 commented 4 years ago

Ready for review!

pat-s commented 4 years ago

looks good 👍

RaphaelS1 commented 4 years ago

deployed

RaphaelS1 commented 4 years ago

Although, I can see it's been added to the bin folder but can't see it in src/contrib, not sure if there's a time delay on this or I've done something wrong

pat-s commented 4 years ago

src/contrib is for Linux. If the runner errored during the deployment run, nothing will be deployed.

Also the folder structure changed for R 4.0 on macOS. I think this needs to be accounted upstream in drat though.

We need to find a logic to have some kind of CRON auto-deploy of all existing learners in mlr3learners.drat to avoid missing sources for specific OS of some learners. This is not trivial though because we are essentially doing a small CRAN setup here.

RaphaelS1 commented 4 years ago

Okay, I'll leave this to you then!