mlr-org / mlr3learners

Recommended learners for mlr3
https://mlr3learners.mlr-org.com
GNU Lesser General Public License v3.0
91 stars 16 forks source link

Connect learner logspline from package logspline #117

Closed RaphaelS1 closed 4 years ago

RaphaelS1 commented 4 years ago

Checklist before requesting a review

RaphaelS1 commented 4 years ago

Ready for review!

https://github.com/mlr3learners/mlr3learners.logspline

pat-s commented 4 years ago

Thanks. As per your comment in the {np} learner you would have to add #nolint to all of the empty functions: https://github.com/mlr3learners/mlr3learners.logspline/blob/e02dd32aca0783b539717a96d775deb39abdede4/R/LearnerDensLogspline.R#L68-L69

This applies to a few more learners that are open for review.

Otherwise 👍

RaphaelS1 commented 4 years ago

deployed - will check the others now