mlr-org / mlr3learners

Recommended learners for mlr3
https://mlr3learners.mlr-org.com
GNU Lesser General Public License v3.0
91 stars 16 forks source link

Connect learner sm.density from package sm #122

Closed RaphaelS1 closed 4 years ago

RaphaelS1 commented 4 years ago

https://github.com/mlr3learners/mlr3learners.sm

Checklist before requesting a review

RaphaelS1 commented 4 years ago

Ready for review, the errors are due to this: https://cran.r-project.org/web/checks/check_results_sm.html

pat-s commented 4 years ago
RaphaelS1 commented 4 years ago

indention does not follow the mlr-style

Not entirely sure which part this refers to, I ran styler again and there was a minor change to one parameter but apart from that not sure which part is not in the right style

pat-s commented 4 years ago

Ah I always get the wording wrong: "indentation" - 2 spaces instead of 4.

styler did this in your last commit: https://github.com/mlr3learners/mlr3learners.sm/commit/3e146f68b4941fe292606a08ba96090a02c36f85

RaphaelS1 commented 4 years ago

okay thanks, will deploy now then