mlr-org / mlr3learners

Recommended learners for mlr3
https://mlr3learners.mlr-org.com
GNU Lesser General Public License v3.0
89 stars 14 forks source link

Add LearnerRegrNnet based on LearnerClassifNnet #238

Closed jemus42 closed 2 years ago

jemus42 commented 2 years ago

As noted on Mattermost, it seemed odd this learner was omitted until now.

This PR adds LearnerRegrNnet as mostly a verbatim copy of LearnerClassifNnet, with the notable exception that the parameter linout = TRUE is forced during training to ensure a linear output suitable for regression tasks.

mllg commented 2 years ago

Nice and clean PR, thanks! 👍

pat-s commented 2 years ago

Thanks again @jemus42!

I've noticed we're missing the paramtest for this learner - do you want to add it yourself? Maybe @mllg can assist in the process?

jemus42 commented 2 years ago

Oh no, I thought I had everything /o\ I'll take a look and open a new PR tomorrow.