Connect learners CoxBoost and cv.CoxBoost from package CoxBoost

RaphaelS1 commented 4 years ago

Ready for review when you are!

https://github.com/mlr3learners/mlr3learners.coxboost

RaphaelS1 commented 4 years ago

I've made all changes to controls, and lintr is passing. Only problem is that all builds are failing and saying I need to add a PAT, which is weird because they were passing recently. Are you aware of any recent updates or changes that could have caused this? Or just a temporary bug?

RaphaelS1 commented 4 years ago

[x] Run styler::style_pkg(style = styler::mlr_style) (install pat-s/styler@mlr-style if not yet done)
[x] Run lintr::lint_package() and fix all issues.
[x] Run usethis::use_tidy_description() to format the DESCRIPTION file.
[x] Check that the learner package name is all lower case, e.g. mlr3learners.partykit.
[x] Ensure that there are not leftover of <package>, <algorithm> or <type> within the learner repo.
[x] Ensure that the "Parameter Check" passed in the CI (both for the train and predict functions)
[x] Ensure that "R CMD check" passed in the CI.
[x] Check that your learners upstream package is not listed in the "Imports" but in the "Suggests" section within the DESCRIPTION file.
[x] If you changed any parameter defaults: Did you document the change (reason and new default) in the help page of the respective learner?
[x] Open a Pull Request in the mlr3learners repo to add your learner to the list of "In Progress" learners. Once approved, it will be moved to the "Approved" section.
[x] Rather than using custom code you can tag these control paramters with "control" in the ParamSet and then query them explicitly in .train()
[x] suggest using mlr3misc::stopf(wrap = TRUE)
[x] I am aiming that we become specific in prefixing functions from external packages, i.e. mlr3misc::invoke(mlr3proba::predict_survreg)

RaphaelS1 commented 4 years ago

Checklist all checked, as well as the other bits from mlr3learners.survival. All checks passing (apart from the mac-devel bug). Ready for review!

pat-s commented 4 years ago

I've made last changes, good to go for drat deployed now ;) And moving it one level up in the learners table :)

RaphaelS1 commented 4 years ago

Thanks! Deployed

mlr-org / mlr3learners

Connect learners CoxBoost and cv.CoxBoost from package CoxBoost #92