search

mlr-org / mlr3misc

Miscellaneous helper functions for mlr3
https://mlr3misc.mlr-org.com
GNU Lesser General Public License v3.0
11 stars 2 forks source link

add logical version require_namespaces #51

Closed RaphaelS1 closed 3 years ago

RaphaelS1 commented 3 years ago

If you hate the idea just close the PR and delete the branch. I just keep re-implementing this in other packages so thought it could be useful to have it globally via mlr3misc.

PR just adds a quietly option to require_namespaces which means that instead of returning string/error it returns TRUE/FALSE, the advantage is then it can be used in documentation and tests more easily.

codecov-io commented 3 years ago

Codecov Report

Merging #51 (8582195) into master (020c405) will decrease coverage by 0.05%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage   80.48%   80.42%   -0.06%     
==========================================
  Files          54       54              
  Lines         748      751       +3     
==========================================
+ Hits          602      604       +2     
- Misses        146      147       +1
Impacted Files Coverage Δ
R/require_namespaces.R 100.00% <100.00%> (ø)
src/keep_in_bounds.c 95.23% <0.00%> (-4.77%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 020c405...8582195. Read the comment docs.