@be-marc can you check whether this works with the tooling that relies on it?
@mllg I am a it confused by how this is supposed to be implemented. The implementation in Learner seems to suggest that private$.base_learner should be implemented, but $base_learner() doesn't do anything except delegate there, not even if (recursive <= 0) return(self) or assert(check_int(recursive), check_numeric(recursive, lower = Inf)).
Consequently, AutoTuner just overwrites the method and does not use private$.base_learner. I also find it weird that recursive = 0 does not return self there.
closes #699 closes #603
@be-marc can you check whether this works with the tooling that relies on it?
@mllg I am a it confused by how this is supposed to be implemented. The implementation in
Learner
seems to suggest thatprivate$.base_learner
should be implemented, but$base_learner()
doesn't do anything except delegate there, not evenif (recursive <= 0) return(self)
orassert(check_int(recursive), check_numeric(recursive, lower = Inf))
. Consequently,AutoTuner
just overwrites the method and does not useprivate$.base_learner
. I also find it weird thatrecursive = 0
does not returnself
there.