search

mlr-org / mlr3proba

Probabilistic Learning for mlr3
https://mlr3proba.mlr-org.com/
GNU Lesser General Public License v3.0
128 stars 20 forks source link

with_package not imported #73

Closed adibender closed 4 years ago

adibender commented 4 years ago

I noticed that with_package was introduced for mboost related functions, however, the withr package is not imported, nor is the with_package function, which breaks tests.

I can make a PR that fixes this, but wanted to make sure that with_package is really necessary (what is special about mboost?), because it means introducing another dependency.

Another Q is whether to put it into imports or suggests?

RaphaelS1 commented 4 years ago

It shouldn't break anything, we are using @mllg version in mlr3misc mlr3misc::with_package Where is it breaking?

adibender commented 4 years ago

hm strange, I got errors, when running tests locally. Will investigate further

adibender commented 4 years ago

hm, appears I had mlr3misc_0.1.6, while mlr3misc_0.1.7 is required.