search

mlr-org / mlr3torch

Deep learning framework for the mlr3 ecosystem based on torch
https://mlr3torch.mlr-org.com
Other
40 stars 7 forks source link

`PipeOpTorchModel` should maybe implement `learner_model` to make `$base_learner()` work #247

Closed sebffischer closed 3 months ago

sebffischer commented 4 months ago

Currently, the default method of set_validate() does not work for something like po("torch_ingress_num") %>>% ... %>>% po("torch_model_regr"), because it does not implement PipeOpLearner.

Alternatively, the set_validate() method should maybe be changed in mlr3pipelines to set $validate for the last pipeop with that property and not the $base_learner().