mlr-org / paradox

ParamHelpers Next Generation
https://paradox.mlr-org.com
GNU Lesser General Public License v3.0
28 stars 7 forks source link

fix test for new data.table #291

Closed MichaelChirico closed 4 years ago

MichaelChirico commented 4 years ago

Closes #290

The (?: ... )? part is to make the test flexible enough to pass before and after the update. [^>]*> would also work i think.

codecov-commenter commented 4 years ago

Codecov Report

Merging #291 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #291   +/-   ##
=======================================
  Coverage   94.42%   94.42%           
=======================================
  Files          21       21           
  Lines         538      538           
=======================================
  Hits          508      508           
  Misses         30       30           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 68db430...914dc24. Read the comment docs.

mllg commented 4 years ago

Thanks, will upload to CRAN tomorrow.

mattdowle commented 4 years ago

Many thanks @mllg and @MichaelChirico.