Learner review - Githubissues

mlr3learners / mlr3learners.rweka

Learner from {RWeka} package for mlr3

0 stars 0 forks source link

Closed pat-s closed 4 years ago

pat-s commented 4 years ago

Thanks!

[x] Apply mlr-style (also to /inst) files
[x] prefix invoke with mlr3misc::
[x] replace do.call() with mlr3misc::invoke()
[x] Check spelling: https://github.com/henrifnk/mlr3learners.rweka/blob/587667e55cfccd7f2c1a9680ac31b5187ccd40d8/R/LearnerClassifJRip.R#L9
[x] replace <- with =

for paramtest on linux openjdk-8-jdk was neccesary... for more infos see commit

All of this should not be needed, the default JDK works - sudo R CMD javareconf should be enough.

henrifnk commented 4 years ago

Hope I fixed all issues Once I have your confirmation I'll transfer it to mlr3learners

pat-s commented 4 years ago

Thanks, looks good! Good work @henrifnk.

You can transfer the repo and try to init the mlr3learners.drat deployment yourself. LMK if you face any issues.