search

mlrawlings / marko-starter

easiest way to create a new marko app
7 stars 1 forks source link

Compatibility: Don't run system commands that are specific to macOS or Linux #7

Open philidem opened 7 years ago

philidem commented 7 years ago

In particular:

rm -rf .cache

We should rely on JavaScript implementations (such as rimraf)

mlrawlings commented 7 years ago

This isn't immediately obvious, but those aren't linux commands they're coming from cash which installs binaries of the same name in node_modules/.bin which gets prepended the PATH for npm scripts.

philidem commented 7 years ago

That's not clear at all and I still think we should avoid spawning another process. rimraf is a good substitute for rm -rf.