mlrv / ng-material-treetable

Angular Material treetable component :deciduous_tree: :heart: ♻️
http://ng-material-treetable.surge.sh
MIT License
99 stars 65 forks source link

Move BrowserModule from TreetableModule. #17

Closed parth42 closed 5 years ago

parth42 commented 5 years ago

BrowserModule already been imported in AppModule so do not need to include it again in TreetableModule. Otherwise users will have an error says, "Error: BrowserModule has already been loaded. If you need access to common directives such as NgIf and NgFor from a lazy loaded module, import CommonModule instead."

mlrv commented 5 years ago

Thanks for reporting this, will definitely fix it as soon as I have some free time

spbalu95 commented 5 years ago

I am also getting same issue when try to integrate ng-material-treetable in angular application.

core.js:15723 ERROR Error: Uncaught (in promise): Error: BrowserModule has already been loaded. If you need access to common directives such as NgIf and NgFor from a lazy loaded module, import CommonModule instead.

mlrv commented 5 years ago

Should be fixed with 0.4.1

TnCoders commented 5 years ago

Are you sure it's Fixed cause i'm using "ng-material-treetable": "^0.5.3", and i got the exact same error:

core.js:9110 ERROR Error: Uncaught (in promise): Error: BrowserModule has already been loaded. If you need access to common directives such as NgIf and NgFor from a lazy loaded module, import CommonModule instead.

bard0x commented 5 years ago

Are you sure it's Fixed cause i'm using "ng-material-treetable": "^0.5.3", and i got the exact same error:

core.js:9110 ERROR Error: Uncaught (in promise): Error: BrowserModule has already been loaded. If you need access to common directives such as NgIf and NgFor from a lazy loaded module, import CommonModule instead.

Same issue for me with the 0.5.3.

TnCoders commented 5 years ago

Should re-open This Closed issues

mlrv commented 5 years ago

Will investigate, thanks for reporting 👍

TnCoders commented 5 years ago

Will investigate, thanks for reporting 👍

Please if you have any temporary solution to fix this please tell me how because i must deliver something today with your Treetable and im Stuck

TnCoders commented 5 years ago

Hello, Is there any news about this bug please ?

coolrb commented 5 years ago

Any update on this Bug? Or workaround

TnCoders commented 5 years ago

Still nothing