search

mlsdpk / alphazero-checkers-pygame

3 stars 0 forks source link

Implement multiple capture mode #18

Closed mlsdpk closed 3 years ago

mlsdpk commented 3 years ago

I've implemented the issue #12 (feature multiple capturing mode). Please review guys. @aungmcs @Awthura @aungpaing98

myogh commented 3 years ago

Nice work @mlsdpk, it almost worked. Upon testing, I found a bug. So if there are multiple opponent pieces available to be captured, the last valid move's location should only be displayed and allowed to press instead of the in-between locations. Otherwise, the player could press the middle valid location which I think could go against the rule of the game.

checkerlog

mlsdpk commented 3 years ago

Nice work @mlsdpk, it almost worked. Upon testing, I found a bug. So if there are multiple opponent pieces available to be captured, the last valid move's location should only be displayed and allowed to press instead of the in-between locations. Otherwise, the player could press the middle valid location which I think could go against the rule of the game.

checkerlog

Yes, the bug you mentioned is the one I would like to discuss with the team as I found out in some checkers online game they allow users to let them decide whether to capture both pieces or only one. Any ideas for this? @aungmcs @Awthura @aungpaing98

myogh commented 3 years ago

Ok then. That rule is good for me. If @Awthura amd @aungpaing98 are fine with it, we could close that issue.

Awthura commented 3 years ago

Looks like it's working smooth. find_valid_moves function is generalized as well. No objections this time.