search

mlsecproject / combine

Tool to gather Threat Intelligence indicators from publicly available sources
https://www.mlsecproject.org/
GNU General Public License v3.0
652 stars 179 forks source link

TESTING: Enrich dns indicators #112

Closed krmaxwell closed 9 years ago

krmaxwell commented 9 years ago

Close #36

krmaxwell commented 9 years ago

So I think the only issue now is that we need to be a little more forgiving on the dates - probably going back in time an extra 24 hours.

I'm really wishing I'd already done #35 now. :P

alexcpsec commented 9 years ago

I'm going to spend some time on this as soon as #121 is stable

krmaxwell commented 9 years ago

man I really need to set up a smaller data set for this.

krmaxwell commented 9 years ago

test data set created, and there are some improvements already. the real issue now is adding the data correctly to the main result set.

krmaxwell commented 9 years ago

@alexcpsec this is ready for your testing! :tada:

krmaxwell commented 9 years ago

@alexcpsec I think this follows your logic correctly now and it seems to return the correct data in the test cases I examined. But you should make sure.

krmaxwell commented 9 years ago

:+1: / :-1: ?

alexcpsec commented 9 years ago

Getting there

alexcpsec commented 9 years ago

This is 100% correct now. We still have query speed challenges on DNSDB, but that is another problem altogether.

krmaxwell commented 9 years ago

:tada: