search

mlsecproject / combine

Tool to gather Threat Intelligence indicators from publicly available sources
https://www.mlsecproject.org/
GNU General Public License v3.0
650 stars 179 forks source link

Issues with upload to CRITs #156

Open apolkosnik-old opened 8 years ago

apolkosnik-old commented 8 years ago

There are couple of issues with the code when trying to use combine with a recent version of CRITs.

  1. Source is not populated, making the indicators invisible to anybody in CRITs
  2. The old vocabulary is used to specify the IP address type
  3. Some possibly useful fields are not populated with useful data

The PR with changes for this is at: #155

The next big improvement would be to use bulk upload functionality, but I'll save that for another PR.

alexcpsec commented 8 years ago

Hi, @frbapolkosnik ! Thanks for this issue and the PR. If I merge this #155 PR, will it solve the issues for you?

Please send an e-mail to alexcp -at- gmail -dot- com with a good e-mail for me to send you a link to our CLA. After that, I can do the merge.

Thanks.

alexcpsec commented 8 years ago

Ah, I will merge it back to 0.1.3 now, and then backport it to our 0.2.0-dev one later.