mlsecproject / combine

Tool to gather Threat Intelligence indicators from publicly available sources
https://www.mlsecproject.org/
GNU General Public License v3.0
653 stars 179 forks source link

Running with "--tiq-test" without "-e" gives an error #58

Closed alexcpsec closed 10 years ago

alexcpsec commented 10 years ago

Maybe the tiq-test option should have a "compulsory" -e?

Storing parsed data in crop.json
Reading processed data from crop.json
Output regular data as CSV to harvest.csv
Traceback (most recent call last):
  File "combine.py", line 42, in <module>
    tiq_output('crop.json', 'enrich.json')
  File "/Users/alexcp/src/combine/baler.py", line 19, in tiq_output
    with open(enr_file, 'rb') as f:
IOError: [Errno 2] No such file or directory: 'enrich.json'
krmaxwell commented 10 years ago

Do you want --tiq-test to imply -e? (Even if not, we still need to handle this better.)

alexcpsec commented 10 years ago

I think so, otherwise we cannot have stuff (asnumbers , asnames and country) for tiq-test to work with.

It should be mandatory.

krmaxwell commented 10 years ago

Sounds like a bug then!

alexcpsec commented 10 years ago

:+1: