search

mlsecproject / combine

Tool to gather Threat Intelligence indicators from publicly available sources
https://www.mlsecproject.org/
GNU General Public License v3.0
653 stars 179 forks source link

Fix config #72

Closed krmaxwell closed 10 years ago

krmaxwell commented 10 years ago

Ready for testing

Implement changes in #68

krmaxwell commented 10 years ago

go go @alexcpsec

alexcpsec commented 10 years ago

So... many... PRs...

krmaxwell commented 10 years ago

Do you want me to stop working on Combine? :trollface:

alexcpsec commented 10 years ago

LOL! No, keep up the good work ;)

alexcpsec commented 10 years ago

Why do we have SafeConfigParser on reaper.py and ConfigParser on the other ones? Can't they all be "safe"?

krmaxwell commented 10 years ago

ah, good catch, I was trying to figure something out.

alexcpsec commented 10 years ago

Made a change so every file checks for the .cfg file. As it were, Thresher and Baler would run anyway.

alexcpsec commented 10 years ago

This seems good to go on my end. Waiting your approval on my change.

krmaxwell commented 10 years ago

Good catch on baler (and the output). I'd left it out of Thresher because it doesn't use any configs and is therefore spurious.

alexcpsec commented 10 years ago

The issue is that then Thresher runs anyway and either runs in an old harvest.json or errors out. This is why I added the check on it even though it does not use it.

krmaxwell commented 10 years ago

Eh, might as well keep the check since it's going to have configs eventually from #23

alexcpsec commented 10 years ago

:shipit: ?

krmaxwell commented 10 years ago

:shipit: