search

mlsecproject / combine

Tool to gather Threat Intelligence indicators from publicly available sources
https://www.mlsecproject.org/
GNU General Public License v3.0
652 stars 179 forks source link

Implement IPv4 and FQDN validation per #15 #85

Closed krmaxwell closed 9 years ago

krmaxwell commented 9 years ago

This does not yet validate the global TLD but should otherwise be ready for testing.

alexcpsec commented 9 years ago

Thanks, will review shortly.

I suggest we spin-off the gTLD validation to a separate issue. That way we can already have this up and going ASAP.

alexcpsec commented 9 years ago

@technoskald Plz review my review :stuck_out_tongue:

krmaxwell commented 9 years ago

Derp, that second parameter is really important! The $ is useful though not critical because we should only be passing it one field, but it certainly doesn't cause any problems.

alexcpsec commented 9 years ago

Actually, the lack of $ was making it accept stuff like 200.234.45.2345, which is clearly wrong. This is because of the way that re.match works.

krmaxwell commented 9 years ago

iiiinteresting. good call on that then! this is why we need a test suite.

alexcpsec commented 9 years ago

@technoskald can I haz :shipit: ?