Closed krmaxwell closed 9 years ago
Thanks, will review shortly.
I suggest we spin-off the gTLD validation to a separate issue. That way we can already have this up and going ASAP.
@technoskald Plz review my review :stuck_out_tongue:
Derp, that second parameter is really important! The $
is useful though not critical because we should only be passing it one field, but it certainly doesn't cause any problems.
Actually, the lack of $
was making it accept stuff like 200.234.45.2345
, which is clearly wrong. This is because of the way that re.match
works.
iiiinteresting. good call on that then! this is why we need a test suite.
@technoskald can I haz :shipit: ?
This does not yet validate the global TLD but should otherwise be ready for testing.