mlsmithjr / transcoder

Python wrapper for ffmpeg for batch and/or concurrent transcoding
GNU General Public License v3.0
117 stars 27 forks source link

fix escaping issues for streaming hosts #20

Open LarsNt opened 4 years ago

LarsNt commented 4 years ago

I had some issues to get the streaming host configuration in cluster mode to work. This might also relate to issue #8. The main problem was that the arguments for the remote host need to be escaped or quoted for the remote shell. The fix for the ffmpeg/hbcli call was taken from the mounted host section.

Additional fixes for the copy commands needed to be added. Since early 2019 openssh has introduced strict filename checking which breaks with quoted filenames when we try to copy back the finished transcode. This can be avoided by specifying the -T option. This again might break on systems with an ssh/scp version that doesn't have this option. Thus I added an configuration option to set the copy command. This also allows to use other tools like rsync (see description in Cluster.md).

I have tested the code on Linux systems but not on Windows.