search

mlswg / mls-implementations

Coordination of implementation and interop specific details
110 stars 14 forks source link

Test Vectors for serialization/de-serialization Tests #172

Closed Aurvandill closed 9 months ago

Aurvandill commented 10 months ago

Hello,

I'm currently writing an MLS implementation in Python and ran into some problems with my serialization/de-serialization.

It would be a great help for people who are developing a library to have some test vectors for just serialization and de-serialization of all relevant classes.

with best regards Ole

raphaelrobert commented 10 months ago

Hi @Aurvandill,

What exactly do you mean by "classes"? In case you mean the structs defined in the spec, I don't think having test vectors is helpful because the structs can always be decomposed in primitives. If you think it might be helpful to check VL vectors, optional fields, and endianness, feel free to propose a PR with the relevant structs.

Aurvandill commented 10 months ago

Hello @raphaelrobert ,

Thanks for the quick reply. Yeah i meant the structs. I will file a PR in the near future with what i think would be helpfull.

Aurvandill commented 9 months ago

closed by b443d17bf80802a1f20d5fab6cbffd7b8dc8e9d3