search

mlt / gtkmm

Native CMake based build of GTKMM 3 on Win32/64 using MS Visual Studio C++ on top of OBS or MSYS2
https://github.com/mlt/gtkmm/wiki
4 stars 4 forks source link

MSVC 2017 #1

Open DaniyelMe opened 7 years ago

DaniyelMe commented 7 years ago

hi Mikhail Titov,

can you please update it, to work with MSVC 2017 i'm getting a lot of errors. (e.g CMake Error at gtkmm/CMakeLists.txt:99 (string): string no output variable specified AND CMake Error at gtkmm/CMakeLists.txt:138 (add_subdirectory): The source directory D:/**/gtkmm/glibmm

btw, wanted to thank you for you great work!

DaniyelMe commented 7 years ago

To fix CMake Error at gtkmm/CMakeLists.txt:99 (string): string no output variable specified please change string(TOUPPER ${CMAKE_BUILD_TYPE} BT) to STRING(TOUPPER "${CMAKE_BUILD_TYPE}" BT)

mlt commented 7 years ago

Thank you for your interest in the project! Do you feel like submitting a pull request? What build type do you use? As far as I remember, quotation is necessary if you have spaces.

As you can see there were not many updates for a while. Perhaps, it is time to revamp it.

DaniyelMe commented 7 years ago

All thanks to you! I think gtkmm is a great tool but it's hard to make it work.

I'm not sure how to do the pull request, I'll try, I have some fixes. I'm just testing it on Visual Studio 2017, so debug I guess. You're right, but if either CMAKE_BUILD_TYPE or BT is not defined, i.e. an empty string, you can get the error